feat: Convert non-IRI claims to IRIs #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachimvh
force-pushed
the
feat/policy-authorization
branch
from
3846a28 to
504260b
Compare
joachimvh
force-pushed
the
feat/literal-identifiers
branch
from
c730281 to
fc988f6
Compare
Collaborator
termontwouter
left a comment
termontwouter
left a comment
There was a problem hiding this comment.
Looks good to me!
termontwouter
previously approved these changes
Nov 26, 2025
joachimvh
force-pushed
the
feat/literal-identifiers
branch
from
fc988f6 to
1c9cac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the ODRL policies are RDF, issues pop up when using non-RDF identifiers. This PR converts incoming ID claims that are not IRIs by encoding the value prepending them with
http://example.com/id/. The URL is just to have something and can be easily changed once an actual base URL has been chosen. It seemed safer to explicitly pick something that will change, instead of a base URL that might still change.